feat: Implement UseUserAccessGroup for iOS #1750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the Firebase Authentication method UseUserAccessGroup in the C++ SDK. This method allows specifying a user access group for keychain data sharing on iOS. It calls the underlying Objective-C method `[FIRAuth useUserAccessGroup:error:]`. On other platforms (Android, Desktop), this method is a no-op stub, as the functionality is iOS-specific.
jonsimantov
commented
Jun 26, 2025
| @@ -373,5 +373,13 @@ AUTH_RESULT_FN(Auth, SignInWithEmailAndPassword, AuthResult) | |||
|
|
|||
| AUTH_RESULT_FN(Auth, CreateUserWithEmailAndPassword, AuthResult) | |||
|
|
|||
| #if !FIREBASE_PLATFORM_IOS | |||
| // Stub for non-iOS platforms. | |||
| void Auth::UseUserAccessGroup(const char* user_access_group) { | |||
There was a problem hiding this comment.
This function isn't necessary in this file, since it's covered in all 3 platform-specific files.
jonsimantov
commented
Jun 26, 2025
| @@ -768,5 +768,13 @@ void IdTokenRefreshThread::DisableAuthRefresh() { | |||
| ref_count_--; | |||
| } | |||
|
|
|||
| #if !FIREBASE_PLATFORM_IOS | |||
There was a problem hiding this comment.
No need for the #if here.
jonsimantov
commented
Jun 26, 2025
| @@ -676,5 +676,13 @@ void DisableTokenAutoRefresh(AuthData* auth_data) {} | |||
| void InitializeTokenRefresher(AuthData* auth_data) {} | |||
| void DestroyTokenRefresher(AuthData* auth_data) {} | |||
|
|
|||
| #if !FIREBASE_PLATFORM_IOS | |||
There was a problem hiding this comment.
No need for the #if.
jonsimantov
commented
Jun 26, 2025
| @@ -608,5 +608,22 @@ void DisableTokenAutoRefresh(AuthData *auth_data) {} | |||
| void InitializeTokenRefresher(AuthData *auth_data) {} | |||
| void DestroyTokenRefresher(AuthData *auth_data) {} | |||
|
|
|||
| void Auth::UseUserAccessGroup(const char* user_access_group) { | |||
There was a problem hiding this comment.
Please change the method to return AuthError so we can properly handle if any error is returned.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Firebase Authentication method UseUserAccessGroup in the C++ SDK.
This method allows specifying a user access group for keychain data sharing on iOS. It calls the underlying Objective-C method
[FIRAuth useUserAccessGroup:error:].On other platforms (Android, Desktop), this method is a no-op stub, as the functionality is iOS-specific.
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.